Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Rename SD-Core charms by adding -k8s as a suffix #57

Merged
merged 4 commits into from
Dec 11, 2023
Merged

chore: Rename SD-Core charms by adding -k8s as a suffix #57

merged 4 commits into from
Dec 11, 2023

Conversation

gatici
Copy link
Contributor

@gatici gatici commented Dec 6, 2023 •
edited
Loading

Description

Add -k8s as a suffix in both github and Charmhub name to follow TE042 .

  • Create new fiveg_nrf library
  • Pin macaroonbakery to 1.3.2 which installed by juju client indirectly through pytest_operator.
    - The next protobuf version 4.21.0 has the breaking changes with the existing code
    - https://protobuf.dev/news/2022-05-06/#python-updates

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have bumped the version of the library

@gatici gatici requested a review from a team as a code owner December 6, 2023 08:48
Gmerold
Gmerold requested changes Dec 6, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
@Gmerold Gmerold mentioned this pull request Dec 6, 2023
Merged
7 tasks
gruyaume
gruyaume requested changes Dec 6, 2023
View reviewed changes
Copy link
Collaborator

@gruyaume gruyaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a bit more to this one and any other one that publishes libs. You will need to register the charm and create a new lib because the existing lib is registered under the old charm name.

Gmerold
Gmerold approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@Gmerold Gmerold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good to me, but there's still the other part (registration and publishing) mentioned by @gruyaume

@gatici gatici force-pushed the TELCO-921-follow-charm-naming-convention branch from a9289a2 to b317019 Compare December 7, 2023 14:21
@gatici gatici force-pushed the TELCO-921-follow-charm-naming-convention branch from b317019 to ed7e984 Compare December 7, 2023 16:57
@gatici gatici force-pushed the TELCO-921-follow-charm-naming-convention branch from ed7e984 to e274af5 Compare December 7, 2023 18:24
@gatici gatici requested a review from gruyaume December 7, 2023 18:26
@gatici gatici force-pushed the TELCO-921-follow-charm-naming-convention branch 2 times, most recently from 7679e20 to 751da46 Compare December 8, 2023 06:57
gruyaume
gruyaume approved these changes Dec 8, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@gatici
Pin macaroonbakery to 1.3.2
49fccb0 
The next protobuf version 4.21.0 has the breaking changes with the existing code
https://protobuf.dev/news/2022-05-06/#python-updates

Signed-off-by: gatici <[email protected]>
@gatici gatici force-pushed the TELCO-921-follow-charm-naming-convention branch from 751da46 to 49fccb0 Compare December 8, 2023 13:10
@gatici gatici merged commit f7e71dd into main Dec 11, 2023
12 checks passed
@gatici gatici deleted the TELCO-921-follow-charm-naming-convention branch December 11, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gmerold Gmerold Gmerold approved these changes

@gruyaume gruyaume gruyaume approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gatici @gruyaume @Gmerold